On Tue, 3 May 2022 20:29:35 GMT, Chris Plummer <cjplum...@openjdk.org> wrote:
>> Alex Menkov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> feedback > > test/hotspot/jtreg/vmTestbase/nsk/jvmti/GetAllThreads/allthr001/allthr001.cpp > line 170: > >> 168: } >> 169: >> 170: void release(JNIEnv *env, jvmtiThreadInfo *info) { > > How about "releaseThreadInfo"? Done. > test/hotspot/jtreg/vmTestbase/nsk/jvmti/GetAllThreads/allthr001/allthr001.cpp > line 238: > >> 236: } >> 237: if (printdump == JNI_TRUE) { >> 238: printf(" >>> %s", inf.name); > > Don't you want a newline here? No. This is pre-existing code. The log looks like: >>> Check: 0 >>> main >>> Reference Handler >>> Finalizer >>> Signal Dispatcher >>> Attach >>> Listener >>> Notification Thread >>> Common-Cleaner >>> MainThread > test/hotspot/jtreg/vmTestbase/nsk/jvmti/GetAllThreads/allthr001/allthr001.cpp > line 240: > >> 238: printf(" >>> %s", inf.name); >> 239: } >> 240: for (j = 0, found = 0; j < thrInfo[ind].unexpected.cnt && >> !found; j++) { > > found = JNI_FALSE found is int, not jboolean. I changed it to bool to be more C++-style ------------- PR: https://git.openjdk.java.net/jdk/pull/8512