On Tue, 17 May 2022 05:55:47 GMT, Ioi Lam <ik...@openjdk.org> wrote: >> Severin Gehwolf has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Use stringStream to simplify controller path assembly > > test/hotspot/gtest/runtime/test_os_linux_cgroups.cpp line 63: > >> 61: ASSERT_STREQ(expected_cg_paths[i], ctrl->subsystem_path()); >> 62: } >> 63: } > > I found it hard to relate the different paths. Could you create a new struct > like this? > > > struct TestCase { > char* mount_path; > char* root_paths; > char* cgroup_path; > char* expected_cg_paths; > } = { > { "/sys/fs/cgroup/memory", // mount > "/", // root, > ....
Yes, makes sense. Will do. ------------- PR: https://git.openjdk.java.net/jdk/pull/8629