On Tue, 2 May 2023 07:32:18 GMT, David Holmes <dhol...@openjdk.org> wrote:
>> Afshin Zafari has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8305083: Remove finalize() from test/hotspot/jtreg/vmTestbase/nsk/share/ >> and /jpda that are used in serviceability/dcmd/framework tests > > test/hotspot/jtreg/vmTestbase/nsk/share/Finalizable.java line 48: > >> 46: * It is implemented in FinalizableObject. >> 47: */ >> 48: public void registerCleanup(); > > Can you not implement this as a default method? It seems much better to force implementors to provide this method. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/13420#discussion_r1182724791
