On Tue, 2 May 2023 09:46:30 GMT, Serguei Spitsyn <sspit...@openjdk.org> wrote:
>> Alex Menkov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Added "no continuations" test case
>
> test/hotspot/jtreg/serviceability/jvmti/vthread/FollowReferences/VThreadStackRefTest.java
> line 38:
>
>> 36: * @test id=no-vmcontinuations
>> 37: * @requires vm.jvmti
>> 38: * @enablePreview
>
> We do not @enablePreview at lines 28 and 38 anymore.
fixed
> test/hotspot/jtreg/serviceability/jvmti/vthread/FollowReferences/VThreadStackRefTest.java
> line 41:
>
>> 39: * @run main/othervm/native
>> 40: * -XX:+UnlockExperimentalVMOptions -XX:-VMContinuations
>> 41: * -Djdk.virtualThreadScheduler.parallelism=1
>
> Why do we need the line 41 in this case?
not needed. removed.
> test/hotspot/jtreg/serviceability/jvmti/vthread/FollowReferences/VThreadStackRefTest.java
> line 208:
>
>> 206:
>> 207: private static void verifyVthreadMounted(Thread t, boolean
>> expectedMounted) {
>> 208: // Hucky, but simple.
>
> Nit: Hucky => Hacky ?
Fixed
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13254#discussion_r1185593295
PR Review Comment: https://git.openjdk.org/jdk/pull/13254#discussion_r1185593199
PR Review Comment: https://git.openjdk.org/jdk/pull/13254#discussion_r1185593067
