On Fri, 5 May 2023 14:53:32 GMT, Daniel D. Daugherty <dcu...@openjdk.org> wrote:
>> src/hotspot/cpu/aarch64/c1_LIRAssembler_aarch64.cpp line 2562:
>>
>>> 2560: Register lock = op->lock_opr()->as_register();
>>> 2561: if (LockingMode == LM_MONITOR) {
>>> 2562: if (op->info() != null) {
>>
>> Hmmm... other places in the same file compare `op->info()` with `nullptr`
>> and not `null`.
>
> I have absolutely no idea why the above diff showed up when I went to view the
> changes for the zero fix. It's not present in the zero fix webrev, but it was
> in the
> "Review new changes" link... sigh... this GitHub thing mystifies me...
It's also interesting that it compiled :-) What is 'null' anyway?
In any case, I am doing a scan of the whole patch and look for any possible
re-introduction of NULL or even null.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/10907#discussion_r1186199522
