On Fri, 5 May 2023 19:10:49 GMT, Coleen Phillimore <[email protected]> wrote:
>> Afshin Zafari has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains seven commits:
>>
>> - Merge master
>> - Merge branch 'master' into _8305083
>> - Merge master
>> - 8305083: 8305083: Remove finalize() from
>> test/hotspot/jtreg/vmTestbase/nsk/share/ and /jpda that are used in
>> serviceability/dcmd/framework tests
>> - 8305083: 8305083: Remove finalize() from
>> test/hotspot/jtreg/vmTestbase/nsk/share/ and /jpda that are used in
>> serviceability/dcmd/framework tests
>> - 8305083: Remove finalize() from test/hotspot/jtreg/vmTestbase/nsk/share/
>> and /jpda that are used in serviceability/dcmd/framework tests
>> - 8305083: Remove finalize() from test/hotspot/jtreg/vmTestbase/nsk/share/
>> and /jpda that are used in serviceability/dcmd/framework tests
>
> test/hotspot/jtreg/vmTestbase/nsk/share/MainWrapper.java line 50:
>
>> 48:
>> 49: // Some tests use this property to understand if virtual threads
>> are used
>> 50: System.setProperty("main.wrapper", wrapperName);
>
> Should this line have been deleted?
Came after merging with master.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13420#discussion_r1188361178
