> Virtual threads are always daemon threads, so tests that previously did not 
> explicitly wait for test threads to exit sometimes fail with virtual threads 
> due to the test exiting before the test threads have exited. A join() for 
> each test thread is needed to fix this issue.
> 
> com/sun/jdi/DeferredStepTest.java is one such tests. I looked at the other 
> com/sun/jdi failures listed in 
> [JDK-8285422](https://bugs.openjdk.org/browse/JDK-8285422) and didn't see any 
> others that might be failing for this same reason.
> 
> I tested locally with `JTREG_TEST_THREAD_FACTORY=Virtual`. I'll also run the 
> appropriate mach5 tier that tests com/sun/jdi with virtual threads.

Chris Plummer has updated the pull request incrementally with one additional 
commit since the last revision:

  some variable renaming

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/14275/files
  - new: https://git.openjdk.org/jdk/pull/14275/files/24dfa505..f83cd766

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=14275&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=14275&range=00-01

  Stats: 6 lines in 1 file changed: 0 ins; 0 del; 6 mod
  Patch: https://git.openjdk.org/jdk/pull/14275.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/14275/head:pull/14275

PR: https://git.openjdk.org/jdk/pull/14275

Reply via email to