On Wed, 9 Aug 2023 07:46:58 GMT, Sergey Bylokhov <s...@openjdk.org> wrote:

> The test uses this code to create a list of valid addresses for the localhost:
> 
>         String hostname = "localhost";
>         List<String> validAddresses = new LinkedList<>();
>         validAddresses.add(hostname);
>         Arrays.stream(InetAddress.getAllByName(hostname))
>                     .forEach(address -> 
> validAddresses.add(address.getHostAddress()));
> 
> It does not work properly if the custom name is set for the 127.0.01 via 
> /etc/hosts file. In that case, the address returned by the "startListen()" 
> will be "SomeCustomName:port", for example we can return it here:
> https://github.com/openjdk/jdk/blob/360f65d7b15b327e2f160c42f318945cc6548bda/src/jdk.jdi/share/classes/com/sun/tools/jdi/SocketTransportService.java#L82

I would recommend fixing the /etc/hosts file in such cases, rather than fixing 
the test to listen on a potential external / non loopback address (which might 
also cause the test to fail on other configurations).

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15203#issuecomment-1672919992

Reply via email to