On Tue, 7 Nov 2023 11:40:02 GMT, Afshin Zafari <[email protected]> wrote:
>> The `find` method now is
>> ```C++
>> template<typename T>
>> int find(T* token, bool f(T*, E)) const {
>> ...
>>
>> Any other functions which use this are also changed.
>> Local linux-x64-debug hotspot:tier1 passed. Mach5 tier1 build on linux and
>> Windows passed.
>
> Afshin Zafari has updated the pull request incrementally with one additional
> commit since the last revision:
>
> function pointer is replaced with template Functor.
src/hotspot/share/gc/parallel/mutableNUMASpace.cpp line 163:
> 161: }
> 162: // That's the normal case, where we know the locality group of the
> thread.
> 163: int i = lgrp_spaces()->find((uint*)&lgrp_id, LGRPSpace::equals);
I guess it is somewhat outside the scope of this PR but I wish this code would
make its mind up about whether the NUMA group ids are `int` or `uint`!
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15418#discussion_r1395182714
