On Wed, 29 Nov 2023 22:38:18 GMT, Serguei Spitsyn <sspit...@openjdk.org> wrote:
>> Alex Menkov has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - feedback >> - prepare_parallel_dum > > src/hotspot/share/services/heapDumper.cpp line 1947: > >> 1945: _complete_number(0), >> 1946: _started(false), >> 1947: _global_writer_lock(new (std::nothrow) Mutex(Mutex::nosafepoint, >> "DumpWriter_lock")) > > We discussed a suggestion to place both lock definitions together: > - lines: 1934 & 1939 > - lines: 1943 & 1947 > Also, it will be nice to add a comment at the start of `DumperController` > constructor to explain why we use `MutexLocker` with the flag > `Mutex::_no_safepoint_check_flag`. Done. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/16665#discussion_r1410022381
