On Fri, 12 Jan 2024 11:28:32 GMT, Joachim Kern <jk...@openjdk.org> wrote:
>> In parseAllowedMask in socketTransport.c, prefixLen of mask is compared with >> a maxValue (32 for IPv4, 128 otherwise). This fails if it is larger than >> 32, because getaddrinfo seems to detect IPv4 family, if IPv6 address has set >> only some of the last 32 Bits. So we take the wrong maxValue. > > Joachim Kern has updated the pull request incrementally with one additional > commit since the last revision: > > following proposals of alexmenkov src/jdk.jdwp.agent/share/native/libdt_socket/socketTransport.c line 400: > 398: /* > 399: * Input is in_addr just because all clients have it. > 400: */ The comment does not make sense anymore: in_addr represents IPv4 address, in6_addr represents IPv6 address. Could you remove it please. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/17374#discussion_r1450935959
