On Thu, 1 Feb 2024 04:17:41 GMT, Martin Doerr <mdo...@openjdk.org> wrote:
>> An assertion is only used for debug builds. Such an error should be handled >> in product builds as well. I think an attempt to load an invalid library >> should simply fail. You may add logging if needed. >> @tstuefe: Do you agree or have another proposal to handle such errors? > > In addition, the nullptr check is important to avoid undefined behavior when > passing `pointer_to_dot` to any string function. Ok. So then may be we can return a nullptr and do a log_info(os) with the correct error report ? @tstuefe @TheRealMDoerr ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/16604#discussion_r1474128334
