On Fri, 2 Feb 2024 08:05:06 GMT, Serguei Spitsyn <sspit...@openjdk.org> wrote:

>> Alex Menkov has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   jcheck
>
> src/hotspot/share/prims/jvmtiTagMap.cpp line 499:
> 
>> 497:     }
>> 498:     // update total_field_number for superclass
>> 499:     total_field_number = start_index;
> 
> Nit: The local variable name `total_field_number` is a little bit confusing 
> because it is instantly decreased here (see also the line 490). I'm not sure 
> what name to suggest though. Maybe the comment at line 498 needs an update to 
> say this number is decreased here.

done

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17661#discussion_r1476887153

Reply via email to