On Mon, 19 Feb 2024 10:05:17 GMT, Suchismith Roy <[email protected]> wrote:
>> J2SE agent does not start and throws error when it tries to find the shared
>> library ibm_16_am.
>> After searching for ibm_16_am.so ,the jvm agent throws and error as dll_load
>> fails.It fails to identify the shared library ibm_16_am.a shared archive
>> file on AIX.
>> Hence we are providing a function which will additionally search for .a file
>> on AIX ,when the search for .so file fails.
>
> Suchismith Roy has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Address review comments
src/hotspot/os/aix/os_aix.cpp line 1185:
> 1183: // Shared object in .so format dont have braces, hence they get
> removed for archives with members.
> 1184: if (error_code == EACCES || error_code == ENOENT) {
> 1185: if (strlen(new_extension) > strlen(old_extension)){
I think this should better be an assertion because the extensions are constants.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16604#discussion_r1494317702
