On Fri, 8 Mar 2024 06:17:06 GMT, David Holmes <[email protected]> wrote:
>> Coleen Phillimore has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Missed a word.
>> - David's comment fixes.
>
> src/hotspot/share/prims/jvmtiGetLoadedClasses.cpp line 121:
>
>> 119: {
>> 120: // To get a consistent list of classes we need MultiArray_lock to
>> ensure
>> 121: // array classes aren't created by another thread during this walk.
>> This walks through the
>
> Thanks for clarifying, though I'm not sure why would care given the set of
> classes could have changed by the time we return them anyway.
I think in this case, we might find an ObjArrayKlass without the mirror since
the Klass is added to the higher_dimension links before the mirror is created.
The lock keeps them both together.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17739#discussion_r1517716370
