On Tue, 12 Mar 2024 11:08:01 GMT, Kevin Walls <[email protected]> wrote:
>jcmd GC.heap_dump has the overwrite flag. >OOM dumping in HeapDumper::dump_heap(bool oome) has a sequence number. There is (with this patch) still just one sequence number and it is incremented by all invocations of alloc_and_create_heapdump_pathname. >I like splitting out alloc_and_create_heapdump_pathname() as this is already a >large part of dump_heap. > Should the comment say, "caller must free the returned pointer". Agree, I will adjust the comment. (and btw regarding your comment on a test, yes I agree there should be a separate test or at least an adjustment/addition to the existing tests) ------------- PR Comment: https://git.openjdk.org/jdk/pull/18190#issuecomment-1991510708 PR Comment: https://git.openjdk.org/jdk/pull/18190#issuecomment-1991514153
