On Wed, 27 Mar 2024 18:31:50 GMT, Kevin Walls <kev...@openjdk.org> wrote:
>> Introduce the jcmd "VM.inspect" to implement access to detailed JVM object
>> information.
>>
>> Not recommended for live production use. Requires UnlockDiagnosticVMOptions
>> and not included in jcmd help output, to remind us this is not a
>> general-purpose customer-facing tool.
>
> Kevin Walls has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Test more pointer types: compiled method and metadata.
src/hotspot/share/services/diagnosticCommand.cpp line 1254:
> 1252: DebuggingContext dc{}; // avoid asserts
> 1253:
> 1254: if (!UnlockDiagnosticVMOptions) {
Drive-by comment: As per the comment from @plummercj this flag should not be
hijacked for this purpose. If you need a VM flag to control this feature then
please add one. Thanks.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17655#discussion_r1547032078
