On Wed, 17 Apr 2024 20:19:49 GMT, Leonid Mesnik <lmes...@openjdk.org> wrote:
> The jdwp tests use debugger and debugee. There is no goal to execute debugger > part with all VM flags, they are needed to be used with debugee VM only. > The change is all tests is to don't use System.exit() and use 'driver' > instead of othervm. > test/hotspot/jtreg/vmTestbase/nsk/share/jpda/DebugeeBinder.java > is updated to correctly set classpath for debugee test/hotspot/jtreg/vmTestbase/nsk/jdwp/ThreadReference/ForceEarlyReturn/forceEarlyReturn001/forceEarlyReturn001.java line 127: > 125: > 126: public static void main (String argv[]) { > 127: int result = run(argv,System.out); Suggestion: int result = run(argv, System.out); test/hotspot/jtreg/vmTestbase/nsk/jdwp/ThreadReference/Interrupt/interrupt001.java line 93: > 91: */ > 92: public static void main (String argv[]) { > 93: int result = run(argv,System.out); Suggestion: int result = run(argv, System.out); test/hotspot/jtreg/vmTestbase/nsk/jdwp/ThreadReference/Name/name001.java line 90: > 88: */ > 89: public static void main (String argv[]) { > 90: int result = run(argv,System.out); Suggestion: int result = run(argv, System.out); test/hotspot/jtreg/vmTestbase/nsk/jdwp/ThreadReference/OwnedMonitors/ownmonitors001.java line 101: > 99: */ > 100: public static void main (String argv[]) { > 101: int result = run(argv,System.out); Suggestion: int result = run(argv, System.out); ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18826#discussion_r1574589699 PR Review Comment: https://git.openjdk.org/jdk/pull/18826#discussion_r1574590099 PR Review Comment: https://git.openjdk.org/jdk/pull/18826#discussion_r1574590307 PR Review Comment: https://git.openjdk.org/jdk/pull/18826#discussion_r1574590456