On Sun, 12 May 2024 02:55:45 GMT, Lei Zaakjyu <d...@openjdk.org> wrote:
>> follow up 8267941
>
> Lei Zaakjyu has updated the pull request incrementally with one additional
> commit since the last revision:
>
> rename
Should we also rename 'HeapRegionType' to 'G1HeapRegionType', then rename the
current 'G1HeapRegionType' to 'G1 HeapRegionTypeEnum'?
src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/g1/G1CollectedHeap.java
line 131:
> 129: if (hr.isInRegion(addr)) {
> 130: return hr;
> 131: }
Since these three methods are G1 specific, I'd prefer not to add the 'g1'
prefix.
-------------
PR Review: https://git.openjdk.org/jdk/pull/18871#pullrequestreview-2051282649
PR Review Comment: https://git.openjdk.org/jdk/pull/18871#discussion_r1597540754
