On Tue, 21 May 2024 17:10:15 GMT, Sebastian Lövdahl <d...@openjdk.org> wrote:
>> 8327114: Attach in Linux may have wrong behaviour when pid == ns_pid >> (Kubernetes debug container) > > Sebastian Lövdahl has updated the pull request incrementally with two > additional commits since the last revision: > > - Remove unused `SELF_PID_NS` > - Rewrite in line with suggestion from Larry Cable On 6/3/24 10:24 AM, Sebastian Lövdahl wrote: > > Hi Larry, no worries. :) > > I can try to look into writing some tests for the elevated use-cases. > but it will be quite much treading of new ground for me, so it could > take some time to get it done. > given that the patch passes all the 'serviceability' and 'container' test cases including the sidecar test - all that appears to be needed is an elevated test case ... looking into that to see if one of the existing container test cases can be extended ... > What's your take, do we need the new tests in this PR, or could it be > done in a follow-up? > > — > Reply to this email directly, view it on GitHub > <https://urldefense.com/v3/__https://github.com/openjdk/jdk/pull/19055*issuecomment-2145749773__;Iw!!ACWV5N9M2RV99hQ!K0MEZ8qTAcfQbuAvzL9Owp185kbnkkocR0vuh5wia4Zlg3fFzKwJo5WgGVBMUSe_N5Hef4teGHbUKcyPg2ou5TXc0g$>, > > or unsubscribe > <https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/ANTA67SLY6ZRE5DP7RNIRR3ZFSREFAVCNFSM6AAAAABHDNNTT6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBVG42DSNZXGM__;!!ACWV5N9M2RV99hQ!K0MEZ8qTAcfQbuAvzL9Owp185kbnkkocR0vuh5wia4Zlg3fFzKwJo5WgGVBMUSe_N5Hef4teGHbUKcyPg2pvqMZDog$>. > You are receiving this because you were mentioned.Message ID: > ***@***.***> > --------------geZr7l60uuZilPFq9LUV0FJ6 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit <!DOCTYPE html><html><head> <meta http-equiv="Content-Type" content="text/html; charset=utf-8"> </head> <body> <br> <br> <div class="moz-cite-prefix">On 6/3/24 10:24 AM, Sebastian Lövdahl wrote:<br> </div> <blockquote type="cite" ***@***.***"> <p dir="auto">Hi Larry, no worries. :)</p> <p dir="auto">I can try to look into writing some tests for the elevated use-cases. but it will be quite much treading of new ground for me, so it could take some time to get it done.</p> </blockquote> <br> given that the patch passes all the 'serviceability' and 'container' test cases including the sidecar test - all that appears to be needed is an elevated test case ... looking into that to see if one of the existing container test cases can<br> be extended ...<br> <br> <blockquote type="cite" ***@***.***"> <p dir="auto">What's your take, do we need the new tests in this PR, or could it be done in a follow-up?</p> <p>—<br> Reply to this email directly, <a href="https://urldefense.com/v3/__https://github.com/openjdk/jdk/pull/19055*issuecomment-2145749773__;Iw!!ACWV5N9M2RV99hQ!K0MEZ8qTAcfQbuAvzL9Owp185kbnkkocR0vuh5wia4Zlg3fFzKwJo5WgGVBMUSe_N5Hef4teGHbUKcyPg2ou5TXc0g$"; moz-do-not-send="true">view it on GitHub</a>, or <a href="https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/ANTA67SLY6ZRE5DP7RNIRR3ZFSREFAVCNFSM6AAAAABHDNNTT6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBVG42DSNZXGM__;!!ACWV5N9M2RV99hQ!K0MEZ8qTAcfQbuAvzL9Owp185kbnkkocR0vuh5wia4Zlg3fFzKwJo5WgGVBMUSe_N5Hef4teGHbUKcyPg2pvqMZDog$"; moz-do-not-send="true">unsubscribe</a>.<br> You are receiving this because you were mentioned.<img alt="" moz-do-not-send="true" width="1" height="1"><span>Message ID: <span><openjdk/jdk/pull/19055/c2145749773</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p> </blockquote> <br> </body> </html> --------------geZr7l60uuZilPFq9LUV0FJ6-- ------------- PR Comment: https://git.openjdk.org/jdk/pull/19055#issuecomment-2146133176
