On Wed, 31 Jul 2024 08:30:47 GMT, Kevin Walls <kev...@openjdk.org> wrote:
> Man page update for jcmd. > > Add updates for the filename options/arguments affected by: > 8334492: DiagnosticCommands (jcmd) should accept %p in output filenames and > substitute PID > > Also: > In the initial "command" summary, remove the text about "If the pid is 0.." > as it is completely duplicated very shortly afterwards in the COMMANDS FOR > JCMD section. > > In Description: > Each diagnostic command has its own set of options and arguments . > > Added "options and" because arguments and options are different and this can > still be confusing. Mentioning them as being different may help. > > Similarly, added a short section describing that jcmds "may take options and > arguments" and further spelling out that options are name=value and arguments > are not, as this can still be confusing. src/jdk.jcmd/share/man/jcmd.1 line 258: > 256: \f[I]filename\f[R]: (Optional) The name of the map file. > 257: If %p is specified in the filename, it is expanded to the JVM\[aq]s PID. > 258: (FILE, \[dq]/tmp/perf-%p.map\[dq]) I'm not sure about this change to FILE from STRING. Are there previous uses of FILE? We still seem to use STRING for JFR.dump, JFR.start, and JFR.stop. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20401#discussion_r1709963776
