On Thu, 12 Sep 2024 16:01:52 GMT, Sonia Zaldana Calles <[email protected]>
wrote:
>> Simon Tooke has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - remove calls to fatal(), remove segment lengt output
>> - use nullptr insted of NULL
>
> src/hotspot/os/windows/memMapPrinter_windows.cpp line 212:
>
>> 210: // 0x00007ffd5bd64000-0x00007ffd5c250000 5160960
>> r--- c-img 0x10d4000 C:\work\jdk\build\work-fastdebug\jdk\bin\server\jvm.dll
>> 211: st->print_cr("from to prot state
>> offset vminfo/file");
>> 212:
>> st->print_cr("=======================================================================");
>
> I think the extended "===" in the header was okay :-)
I stuck a couple extra '===' in, just for you. I do think it looks a bit
better.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20597#discussion_r1758974585
