On Thu, 6 Feb 2025 17:34:01 GMT, Serguei Spitsyn <[email protected]> wrote:
>> Alex Menkov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> feedback
>
> test/hotspot/jtreg/serviceability/attach/AttachAPIv2/StreamingOutputTest.java
> line 70:
>
>> 68:
>> 69: private static void attach(LingeredApp app, boolean clientStreaming,
>> boolean vmStreaming) throws Exception {
>> 70: HotSpotVirtualMachine vm =
>> (HotSpotVirtualMachine)VirtualMachine.attach(String.valueOf(app.getPid()));
>
> Q: It is confusing that both boolean arguments are not used. Would you like
> to get rid of them?
Dropped.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23405#discussion_r1945880212
