On Wed, 4 Jun 2025 17:24:07 GMT, Aleksey Shipilev <sh...@openjdk.org> wrote:
> Please file the follow-ups to figure out the memory ordering story in > `JfrCPUTimeTraceQueue`. I created a preliminary issue at https://bugs.openjdk.org/browse/JDK-8358616 > src/hotspot/share/runtime/vmOperation.hpp line 119: > >> 117: template(RendezvousGCThreads) \ >> 118: template(CPUTimeSamplerThreadInitializer) \ >> 119: template(CPUTimeSamplerThreadTerminator) \ > > I think these better be prefixed with `JFR`. E.g.: > `JFRInitializeCPUTimeSampler` / `JFRTerminateCPUTimeSampler`? Good point ------------- PR Comment: https://git.openjdk.org/jdk/pull/25302#issuecomment-2940863550 PR Review Comment: https://git.openjdk.org/jdk/pull/25302#discussion_r2127113247
