On Fri, 21 Nov 2025 11:50:58 GMT, Alan Bateman <[email protected]> wrote:
>> Mat Carter has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove single whitespace
>
> test/hotspot/jtreg/runtime/cds/appcds/aotCache/HotSpotAOTCacheMXBeanTest.java
> line 45:
>
>> 43: import jdk.test.lib.process.OutputAnalyzer;
>> 44:
>> 45: public class HotSpotAOTCacheMXBeanTest {
>
> In addition to testing the endRecording operation, we also need to test both
> the direct and indirect access to the MXBean. The test currently obtains a
> proxy with newPlatformMXBeanProxy (good) but the direct access with
> ManagementFactory.getPlatformMXBean is not tested right now.
>
> Another thing to test is that getObjectName returns the expected object name.
Agreed and I will add these additional tests in a subsequent PR
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28010#discussion_r2585561932
