On Wed, 21 Jan 2026 18:48:45 GMT, Larry Cable <[email protected]> wrote:

>> modified the pre-existing VM.classes jcmd to add a 'location' option, that 
>> when specified, will (natively) attempt to obtain the value (if non-null) of 
>> the location URL of the CodeSource of each classes ProtectionDomain.
>> 
>> effectively:
>> 
>> someObject.getClass().getProtectionDomain().getCodeSource().getLocation().toExternalForm()
>> 
>> (where interim oops are null-checked)
>
> Larry Cable has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   JDK-8327246: fixed initialization bug in AOT cache sharing summary code

Ah ok thanks Larry - we always may show 'S', but I missed the _location check 
before printing s and d.  It surprises me that the flags that can be printed 
are dependent on the -location flag.
  
As we only show _aot_static and dynamics if _location is set, I guess I 
expected one if (_location) check before the 
AOTMetaspace::in_aot_cache_static_region and 
(AOTMetaspace::in_aot_cache_dynamic_region checks.

The "-location" help is: "Print class file (and AOT cache) location url (if 
available)"
..but it's more than that, it affects what flags we might print as well.  Is it 
simpler to just show the flags always?

Actually, we already have a problem that the "Some classes are annotated with 
flags.." text is part of the "-verbose" flag description, but that is wrong.  
It should be in the description() method in the .hpp file?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/29048#issuecomment-3807013254

Reply via email to