On Fri, 10 Apr 2026 00:11:27 GMT, Xueming Shen <[email protected]> wrote:
>> Jatin Bhateja has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 49 commits: >> >> - Post merge fixes >> - Merge branch 'master' of http://github.com/openjdk/jdk into JDK-8370691 >> - Merge branch 'master' of http://github.com/openjdk/jdk into JDK-8370691 >> - Fix float16 handling for toIntegralChecked routine, some other cleanups >> - Merge branch 'master' of http://github.com/openjdk/jdk into JDK-8370691 >> - More cleanups >> - Merge branch 'master' of http://github.com/openjdk/jdk into JDK-8370691 >> - Merge branch 'master' of http://github.com/openjdk/jdk into JDK-8370691 >> - More cleanups >> - Merge branch 'master' of http://github.com/openjdk/jdk into JDK-8370691 >> - ... and 39 more: https://git.openjdk.org/jdk/compare/1d290109...c95e3c6e > > src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Float16Vector.java > line 52: > >> 50: /** >> 51: * A specialized {@link Vector} representing an ordered immutable >> sequence of >> 52: * {@code short} values. > > I’m not sure whether this has been discussed and decided before, but should > we use “sequence of Float16 values” instead of “short”? In order to load/store a vector, backing storage needs to have contiguous layout of float16 values. Like all other vector types, backing storage for Float16Vector is a primitive type array of short values, as short is a carrier type for Float16. In long term once Valhalla flat arrays are integrated, we will migrate existing backing storage to Float16![]. Please refer to following comments in the support. https://github.com/openjdk/jdk/pull/28002#issuecomment-3523722566 https://github.com/openjdk/jdk/pull/28002#pullrequestreview-3636482293 ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/28002#discussion_r3063647211
