On Tue, 5 May 2026 14:47:56 GMT, Johan Sjölen <[email protected]> wrote:
>> Kevin Walls has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> TableStatistics not static, remove Windows special case
>
> src/hotspot/share/classfile/dictionary.cpp line 242:
>
>> 240:
>> 241: void Dictionary::print_table_statistics(outputStream* st, const char*
>> table_name) {
>> 242: NOT_WINDOWS(static) TableStatistics ts; // Avoid atexit for static
>> destructor on Windows
>
> I think that we can just delete this static, I opened a separate PR for it:
> https://github.com/openjdk/jdk/pull/31039
Excellent, yes I nearly went that far as well. Surely these are not often
used, quite niche commands (VM.stringtable, VM.symboltable,
VM.systemdictionary).
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/31011#discussion_r3197465423
