On Tue, 2 Jun 2026 06:28:30 GMT, David Holmes <[email protected]> wrote:
>> David Simms has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 2754 commits: >> >> - Merge remote-tracking branch 'valhalla/lworld' into >> jep401_sub_review_8317278 >> - Merge >> >> Merge jdk-27+24 >> - 8385674: [lworld] TestNullableInlineTypes.java fails after JDK-8325632 >> >> Reviewed-by: mchevalier >> - 8385652: [lworld] RedefineClasses should use stack map frame name >> >> Reviewed-by: fparain >> - 8384107: [lworld] Update runtime/contended tests to run the same testing >> for value classes >> >> Reviewed-by: fparain, lmesnik >> - 8385600: [lworld] DA/DU issues with strict fields >> >> Reviewed-by: vromero >> - 8384897: [lworld] this.staticField should be restricted in early >> construction context >> >> Reviewed-by: liach, vromero >> - 8385601: [lworld] Update testing documentation for the ValueClassPlugin >> jtreg option >> >> Reviewed-by: lmesnik >> - 8385569: [lworld] Apply JDK-8343767 to Valhalla specific StubRoutines >> >> Reviewed-by: fparain, vlivanov >> - 8385581: [lworld] Remove the experimental JVMCI feature >> 8382708: [lworld] JVMCI support for Value Objects >> 8372605: [lworld] >> compiler/jvmci/jdk.vm.ci.runtime.test/src/jdk/vm/ci/runtime/test/TestResolvedJava*.java >> fail with --enable-preview >> >> Reviewed-by: thartmann >> - ... and 2744 more: https://git.openjdk.org/jdk/compare/2c7efc08...e0250a38 > > src/hotspot/share/classfile/fieldLayoutBuilder.hpp line 252: > >> 250: // This class has two methods to generate layout: one for identity >> classes >> 251: // and one for inline classes. The rational for having two methods >> 252: // is that each kind of classes has a different set goals regarding > > Suggestion: > > // and one for inline classes. The rationale for having two methods > // is that each kind of class has a different set of goals regarding > Code changes resulting from the review process should be made in > [valhalla/lworld](https://github.com/openjdk/valhalla/). > > valhalla/lworld is currently updated from jdk/master whenever a weekly [jdk > tag](https://github.com/openjdk/jdk/tags) is created. At that time, code > changes from valhalla/lworld will be propagated to the master pull request > and to all sub-review pull requests, including this one. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31122#discussion_r3341174153
