On Mon, 20 Jul 2026 08:29:29 GMT, Alan Bateman <[email protected]> wrote:

>> Kieran Farrell has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   revert mistaken change
>
> src/java.base/share/classes/sun/launcher/LauncherHelper.java line 193:
> 
>> 191:     }
>> 192: 
>> 193:     public static byte[] showSettingsBytes(String optionFlag,
> 
> @kieran-farrell  Have you looked into moving the showSettings code to 
> jdk.internal to be with the other supporting methods? That would allow it be 
> used by the java launcher and the upcall from the VM.

Hi Alan, I've relocated these methods in the latest commit

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/31742#discussion_r3624443102

Reply via email to