On Fri, 26 Jun 2026 10:57:29 GMT, Thomas Schatzl <[email protected]> wrote:

>> Ivan Walulya has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   StefanK review
>
> src/hotspot/share/gc/g1/g1HeapRegionSet.hpp line 33:
> 
>> 31: #define assert_heap_region_set(p, message)  \
>> 32:   do {                                      \
>> 33:     assert((p), "[%s] %s ln: %u",           \
> 
> I believe the `ln` meant `length`, so needs to be renamed too. Maybe spell it 
> out completely (num_regions).
> 
> Same in the other asserts.

+1

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/31688#discussion_r3721474819

Reply via email to