On Tue, 18 Aug 2026 12:49:33 GMT, Coleen Phillimore <[email protected]> wrote:
>> This patch removes the work to save the Method name in the backtrace that >> was used for the case where redefinition could delete the method that was on >> the stack in the stack trace, but saved then deleted with redefinition >> later. RedefineClasses' ability to add/delete methods has been deprecated >> for many releases, so adding code and memory for this case is wasting space >> and time. This change speeds up Throwable microbenchmarks by about 10-30%, >> and speeds up DaCapo pmd by a bit. >> >> Remerged with the change to factor out javaStackTraceClasses. >> >> Tested with tier1-4. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Coleen Phillimore has updated the pull request incrementally with one > additional commit since the last revision: > > Matias comments. Still good. Ignore the suggested change - I did that before realizing it was just moved code. src/hotspot/share/classfile/javaStackTraceClasses.cpp line 234: > 232: new_head->obj_at_put(trace_hidden_offset, nullptr); > 233: > 234: _head = new_head(); Suggestion: _head = new_head(); ------------- Marked as reviewed by dholmes (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/32202#pullrequestreview-4966161708 PR Review Comment: https://git.openjdk.org/jdk/pull/32202#discussion_r3808247800
