> Please review this small fix.
> 
> Configuring the same log file as `vm.log`, `$PWD/vm.log`, and `./vm.log` 
> creates separate outputs, splitting the messages across multiple files.
> 
> **Fix:**
> 
> Let each output match its own name through `matches_name()`. For file 
> outputs, also check `os::same_files()` so different paths to the same file 
> reuse the existing output.
> 
> **Testing:**
> 
> - Added `TestEquivalentLogFilePaths.java`.
> - `gtest:LogConfiguration/server`: 21 passed, 0 failed.
> - `test/hotspot/jtreg/serviceability/logging`: 7 passed, 0 failed.
> - `test/hotspot/jtreg/runtime/logging`: 33 passed, 0 failed.
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

Yunbo Zhang has updated the pull request incrementally with one additional 
commit since the last revision:

  8392135: Unified logging creates extra log files
  
  Synchronize file identity comparisons with rotation using the existing 
semaphore, and add a concurrent alias-matching regression test.

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/33090/files
  - new: https://git.openjdk.org/jdk/pull/33090/files/b682f4d1..31956bba

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=33090&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=33090&range=01-02

  Stats: 70 lines in 3 files changed: 55 ins; 13 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/33090.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/33090/head:pull/33090

PR: https://git.openjdk.org/jdk/pull/33090

Reply via email to