On Mon, 2 Nov 2026 18:34:48 GMT, Chris Plummer <[email protected]> wrote:
>> Long Yang has updated the pull request with a new target base due to a merge >> or a rebase. The pull request now contains eight commits: >> >> - Enable TestJhsdbJstackMixedWithXComp.java on riscv64 while excluding QEMU >> environments >> - Enable -fasynchronous-unwind-tables for linux-riscv64 >> - Add try/catch for memory-read exceptions in getSenderFP >> - RISC-V: Use compiler-defined macros for DWARF register selection >> - Recover caller return addresses across save helpers >> - Use the CIE return-address column instead of the hard-coded RA register >> - Add comment >> - 8391637: On the RISC-V platform, TestJhsdbJstackMixed has a certain >> probability of failure > > Something is messed up with the commit history. It says my review is out of > date and was based on > [d8770661](https://git.openjdk.org/jdk/pull/33374/files/d8770661a58f30c16fac2c8cf4d11b0ceb0290f9), > but > [d8770661](https://git.openjdk.org/jdk/pull/33374/files/d8770661a58f30c16fac2c8cf4d11b0ceb0290f9) > no longer exists. Also, when I try to review all commits since my last > review, it says there are none. @plummercj Sorry for disrupting your review. My rebase and force-push rewrote the commit IDs, so d8770661 is no longer in the current branch history. I knew that rebasing would rewrite the commit IDs and invalidate incremental review comparisons. However, the earlier review discussion specifically suggested merge [JDK-8395826](https://bugs.openjdk.org/browse/JDK-8395826) first and then rebasing this PR, so I followed. I should have clarified whether merging master would be preferable before proceeding. To clarify the code changes: both this PR and [JDK-8395826](https://bugs.openjdk.org/browse/JDK-8395826) modified only one line in dwarf.cpp, making exactly the same change: - while ((_buf < end) && (_current_pc < pc)) { + while ((_buf < end) && (_current_pc <= pc)) { Master now contains that change https://github.com/openjdk/jdk/blob/6cf31a5e10084bd171a63908deb8bfce7443e448/src/jdk.hotspot.agent/linux/native/libsaproc/dwarf.cpp#L176 After rebasing, dwarf.cpp therefore no longer appears in this PR’s diff. All other diff hunks are unchanged compared with the PR immediately before the force-push, not necessarily the older d8770661 version you reviewed. Could you please review the current version again? I’m sorry for the extra review work caused by the rebase. ------------- PR Comment: https://git.openjdk.org/jdk/pull/33374#issuecomment-6593473376
