On Mon, 21 Sep 2026 09:12:15 GMT, Stefan Karlsson <[email protected]> wrote:

>> src/hotspot/cpu/aarch64/sharedRuntime_aarch64.cpp line 2975:
>> 
>>> 2973:   if (vk->supports_nullable_layouts()) {
>>> 2974:     // Zero the null marker (setting it to 1 would be better but 
>>> would require an additional register)
>>> 2975:     __ strb(zr, Address(r0, vk->layouts().null_marker_offset()));
>> 
>> I must say that I find the older code more pleasant to read. Why not keep 
>> the `null_marker_offset()` and implement it as a 
>> `vk->layouts().null_marker_offset()`?
>
> The same goes for other usages where external code is querying a ValueKlass.

Made these changes to my suggestion branch.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/32276#discussion_r4561167472

Reply via email to