Guillaume,

The more I look at this the more I come up with questions :)

The AbstractXBeanDeployer and AbstractWsdl1Deployer are both part of the
inheritance hierarchy of AbstractDeloyer.  Should there actually be a
validate method on the AbstractDeployer instead which would allow for the
validation across the entire deployer hierarchy?  I am assuming here that
the idea was to introduce a way to have both a generic and specific
validation hierarchy.  And further, would the other endpoint deployers
require calls to validate after their endpoints are created?  The endpoint
deployers involved here are (Other than AbstractWsdl1Deployer and
AbstractXBeanDeployer):

BPEDeployer
ScaDeployer
WSNDeployer

Currently there would be no additional validations but the introduction of a
validate method would be more consistent if it was applied across all the
endpoint deployers instead of in just a couple.

Grant M.

On 11/10/06, Grant McDonald (JIRA) <[EMAIL PROTECTED]> wrote:

    [
https://issues.apache.org/activemq/browse/SM-536?page=comments#action_37404]

Grant McDonald commented on SM-536:
-----------------------------------

I thought as much.  I'll update it to throw DeploymentException and add in
a validate method to the AbstractWsd1Deployer

> The defaultMep is a mandatory attribute on consumer endpoints and should
be checked
>
-----------------------------------------------------------------------------------
>
>                 Key: SM-536
>                 URL: https://issues.apache.org/activemq/browse/SM-536
>             Project: ServiceMix
>          Issue Type: Bug
>          Components: servicemix-http, servicemix-jms
>            Reporter: Guillaume Nodet
>         Assigned To: Grant McDonald
>         Attachments: SM-536.patch
>
>


--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://issues.apache.org/activemq/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



Reply via email to