Also I think i saw that Brady submitted an API Freeze request couple of days ago to get agreement from the other 3 projects the projects to integrate the patches at the same time.
From: [email protected] To: [email protected]; [email protected]; [email protected] Date: Tue, 2 Aug 2016 19:02:00 +0000 Subject: Re: [sfc-dev] Distribution check failing Completely agree. My point is that as a whole the code might be working fine but there integration thing is missing That patches will not pass the singletests (one of them i think dont even pass the unitary ones). So some work is required to finish the integration. From: [email protected] To: [email protected]; [email protected]; [email protected] Subject: RE: [sfc-dev] Distribution check failing Date: Tue, 2 Aug 2016 18:39:22 +0000 Hello Patricio But that’s not going to help with the commit verification done with Jenkins as each patch is evaluated independently. Maybe an option would be to step up the openflowplugin version and then on the dependency of dependent projects. BR Jaime From: [email protected] [mailto:[email protected]] On Behalf Of Patricio Latini Sent: martes, 02 de agosto de 2016 19:19 To: Diego Jesus Granados Lopez <[email protected]>; [email protected] Subject: Re: [sfc-dev] Distribution check failing Diego, I think you have to apply the 4 patches in question and compile the 4 packages (openflowplugin sfc groupbasedpolicy netvirt) preferably in that order as the patches add references to other packages, so i think it is a no go to compile just a single patch. >From my testing the 4 patches compile ok with (-dskiptests), however there are >some problem with the tests in the groupbasedpolicy package. From: [email protected] To: [email protected] Date: Tue, 2 Aug 2016 15:02:29 +0000 Subject: Re: [sfc-dev] Distribution check failing Hi, I think we got the root cause for this. It is Yi Yang's patch in the openflowplugin project (https://git.opendaylight.org/gerrit/#/c/37937/ ) itself what triggers the failed integration test (making sfc's feature installation to fail). Problem is that the patch includes changes (including deletions) in several yang definitions in openflowplugin which were used by SFC, without changing yang / openflowplugin versions. So the merge job of YY's openflowplugin patch alone fails (it is executed alone, without the corresponding patch in the SFC project being included) We have reproduced this locally by generating a version of openflowplugin with the patch, then compiling sfc (it fails; log attached). Not sure of the best solution for this: my best guess is that the patch should somehow explicit the version change in order to be backward compatible (in terms of not breaking sfc). As I said, not really sure on the best solution BR, Diego From: [email protected] [mailto:[email protected]] On Behalf Of Luis Gomez Sent: viernes, 29 de julio de 2016 22:51 To: [email protected] Subject: [sfc-dev] Distribution check failing Hi SFC devs, Boron distribution-check is failing with: Error Message Can't install feature odl-integration-all/0.5.0-SNAPSHOT: Could not start bundle mvn:org.opendaylight.sfc/sfc-openflow-renderer/0.3.0-SNAPSHOT in feature(s) odl-sfc-openflow-renderer-0.3.0-SNAPSHOT: The bundle "org.opendaylight.sfc.openflow-renderer_0.3.0.SNAPSHOT [425]" could not be resolved. Reason: Missing Constraint: Import-Package: org.opendaylight.sfc.util.openflow; version="[0.3.0,1.0.0)" Please address the issue as this is impacting everybody in ODL. BR/Luis _______________________________________________ sfc-dev mailing list [email protected] https://lists.opendaylight.org/mailman/listinfo/sfc-dev _______________________________________________ sfc-dev mailing list [email protected] https://lists.opendaylight.org/mailman/listinfo/sfc-dev
_______________________________________________ sfc-dev mailing list [email protected] https://lists.opendaylight.org/mailman/listinfo/sfc-dev
