Hi SFC-devs,

I am working on moving the project to Blueprint. Here is the patch for the
sfc-provider bundle: https://git.opendaylight.org/gerrit/#/c/42661
I am able to load the feature 'odl-sfc-provider' correctly and the bundles
are also started correctly in karaf. However, I am seeing some Unit Test
failures. It would be great if someone reviewed the patch and provide their
comments.

Failed tests:
  SfcProviderRpcTest.readRenderedServicePathFirstHopTest:577->writeRSP:548
expected:<[rspName1-Reverse]> but was:<[unittest-rsp-1]>
  SfcProviderRpcTest.readRspFirstHopBySftListTest:650->writeRSP:548
expected:<[rspName1-Reverse]> but was:<[unittest-rsp-1]>
  SfcProviderRenderedPathAPITest.testCreateRenderedServicePathAndState:207
expected:<[rspName1-Reverse]> but was:<[unittest-rsp-1]>
  
SfcProviderRenderedPathAPITest.testCreateRenderedServicePathEntryUnsuccessful2:291
Must be null expected null, but was:<RenderedServicePath
[_key=RenderedServicePathKey [_name=RspName [_value=unittest-rsp-1]],
_name=RspName [_value=unittest-rsp-1], _pathId=2130,
_renderedServicePathHop=[RenderedServicePathHop [_hopNumber=0,
_key=RenderedServicePathHopKey [_hopNumber=0],
_serviceFunctionForwarder=SffName [_value=SFF1],
_serviceFunctionForwarderLocator=SffDataPlaneLocatorName
[_value=196.168.66.101], _serviceFunctionName=SfName
[_value=unittest-fw-1], _serviceIndex=255, augmentation=[]],
RenderedServicePathHop [_hopNumber=1, _key=RenderedServicePathHopKey
[_hopNumber=1], _serviceFunctionForwarder=SffName [_value=SFF2],
_serviceFunctionForwarderLocator=SffDataPlaneLocatorName
[_value=196.168.66.102], _serviceFunctionName=SfName
[_value=unittest-dpi-1], _serviceIndex=254, augmentation=[]],
RenderedServicePathHop [_hopNumber=2, _key=RenderedServicePathHopKey
[_hopNumber=2], _serviceFunctionForwarder=SffName [_value=SFF3],
_serviceFunctionForwarderLocator=SffDataPlaneLocatorName
[_value=196.168.66.103], _serviceFunctionName=SfName
[_value=unittest-napt-1], _serviceIndex=253, augmentation=[]],
RenderedServicePathHop [_hopNumber=3, _key=RenderedServicePathHopKey
[_hopNumber=3], _serviceFunctionForwarder=SffName [_value=SFF4],
_serviceFunctionForwarderLocator=SffDataPlaneLocatorName
[_value=196.168.66.104], _serviceFunctionName=SfName
[_value=unittest-http-header-enrichment-1], _serviceIndex=252,
augmentation=[]], RenderedServicePathHop [_hopNumber=4,
_key=RenderedServicePathHopKey [_hopNumber=4],
_serviceFunctionForwarder=SffName [_value=SFF5],
_serviceFunctionForwarderLocator=SffDataPlaneLocatorName
[_value=196.168.66.105], _serviceFunctionName=SfName
[_value=unittest-qos-1], _serviceIndex=251, augmentation=[]]],
_serviceChainName=SfcName [_value=unittest-chain-1],
_startingIndex=255, _transportType=class
org.opendaylight.yang.gen.v1.urn.cisco.params.xml.ns.yang.sfc.sl.rev140701.Mpls,
augmentation=[]]>
  SfcProviderServiceChainAPITest.testCreateReadServiceFunctionChain:78
Must be equal expected:<[SfcServiceFunction{getName=firewall,
getType=SftTypeName [_value=firewall], augmentations={}},
SfcServiceFunction{getName=dpi, getType=SftTypeName [_value=dpi],
augmentations={}}, SfcServiceFunction{getName=napt,
getType=SftTypeName [_value=napt44], augmentations={}},
SfcServiceFunction{getName=http-header-enrichment, getType=SftTypeName
[_value=http-header-enrichment], augmentations={}},
SfcServiceFunction{getName=qos, getType=SftTypeName [_value=qos],
augmentations={}}]> but was:<[]>
  
SfcServiceFunctionLoadBalanceSchedulerAPITest.testServiceFunctionLoadBalanceScheduler:235
Must be equal expected:<4> but was:<3>
  SfcServiceFunctionSchedulerAPITest.testBasicEnvSetup:186 Must be
equal expected:<7> but was:<3>
  SfcServiceFunctionSchedulerAPITest.testServiceFunctionRoundRobinScheduler:258
Must be equal expected:<simple_f[irewall]_110> but
was:<simple_f[w]_110>

Thanks,

-- 
*Rashmi Pujar*
*Inocybe Technologies*
_______________________________________________
sfc-dev mailing list
[email protected]
https://lists.opendaylight.org/mailman/listinfo/sfc-dev

Reply via email to