Hi, > We did the following changes in sflphone-client-kde while trying to > make call-making working in IP2IP mode
I can call IP2IP without this patch, writing sip:192.168.3.100 call the IP phone just fine. I can not reproduce the issue. > We are facing some problems like on-hold tone wasnt being played in ip2ip > mode. There is no on-hold tone on IP2IP as there is no SIP server to generate it. We don't think SFLPhone-daemon should emulate one, so this one is tagged "wont-fix". > Is it the consequence of the changes we made? We also figured out that > notifications regarding destination unavailable in ip2ip showed an on-hold > icon. I recommend avoiding making the changes, they are not needed and will cause SEGFAULTS By the way, I just pushed an updated version of the client. It work once again with the latest daemon (v1.1-rc). I am working full-time on it, so if you have questions or comment, it is time. ----- Original Message ----- From: "Vipul Mahajan" <[email protected]> To: [email protected] Sent: Monday, 9 April, 2012 10:57:04 AM Subject: Re: [SFLphone] Error with SFLPhone KDE Hello again, We did the following changes in sflphone-client-kde while trying to make call-making working in IP2IP mode, ===========Call.cpp========= void Call::call() { CallManagerInterface & callManager=CallManagerInterfaceSingleton::getInstance(); qDebug() << "account = " << m_Account; if(m_Account.isEmpty()) { qDebug() << "Account is not set, taking the first registered."; this->m_Account = CallModelConvenience::getCurrentAccountId(); } //if(!m_Account.isEmpty()) { qDebug() << "Calling " << m_CallNumber << " with account " << m_Account \ << ". callId : " << m_CallId; callManager.placeCall(m_Account, m_CallId, m_CallNumber); this->m_Account = m_Account; this->m_PeerPhoneNumber = m_CallNumber; if (m_pContactBackend) { Contact* contact = m_pContactBackend->getContactByPhone(m_PeerPhoneNumber); if (contact) m_PeerName = contact->getFormattedName(); } this->m_pStartTime = new QDateTime(QDateTime::currentDateTime()); this->m_HistoryState = OUTGOING; /* } else { qDebug() << "Trying to call " << m_TransferNumber << " with no account\ registered . callId : " << m_CallId; this->m_HistoryState = NONE; throw "No account registered!"; } */ } ============================ Now that we are able to make and receive calls, we are worried whether it is the right way of doing it and whether it has any effect on other parts of the application. We are facing some problems like on-hold tone wasnt being played in ip2ip mode. Is it the consequence of the changes we made? We also figured out that notifications regarding destination unavailable in ip2ip showed an on-hold icon. Can you please help us find out the way to fix this and maybe generate an error message playback. please help us. _______________________________________________ SFLphone mailing list [email protected] http://lists.savoirfairelinux.net/mailman/listinfo/sflphone _______________________________________________ SFLphone mailing list [email protected] http://lists.savoirfairelinux.net/mailman/listinfo/sflphone
