Chris,

This looks good to me, but at some point you may want to apply the below 
changes ....

Paul

chris zhu wrote:
> 
> Please help to review the CR6784907 "specify path to ginstall, and add 
> gnu-coreutils as a dependency in rbconfig.rb".
> The webrev is ready on 
> http://cr.opensolaris.org/~chriszhu/CR6784907-webrev/
> And the following importance gems are tested: rails, mongrel, thin, 
> eventmachine, RubyInline, image_science(with FreeImage)

1. usr/src/cmd/ruby18/postinstall-ruby
    Roland Mainz wrote:
    > use /usr/bin/ksh93 or /usr/bin/bash for install-sfw* and add
    > a $ set -o errexit # at the beginning and replace
    > ". ${SRC}/tools/install.subr" with
    > "source ${SRC}/tools/install.subr" (the
    > idea is to catch failures in the script and abort it at
    > that point, right now the script will just continue)

-- 
----------------------------------------------------------------------
Paul Cunningham
Software Engineer
Tadpole Business Unit

Reply via email to