Fenye, fenye bao - Sun Microsystems - Beijing China wrote: > Hi Paul, > Any other comment?
This is still not a proper review (I haven't got time for that), but here are a few more comments, see below .... Paul > > Paul Cunningham wrote: >> Fenye, >> >> I haven't reviewed this, but here is a quick comment ... >> >> in the prototype_* files you should probably remove the 'write >> permission' from the new installed files. >> >> paul >> >> fenye bao - Sun Microsystems - Beijing China wrote: >> >>> Hi all, >>> >>> Requesting a code review for the supports of libusb-64bit and >>> openusb-64bit. Please >>> help review on this, any feedback would be very appreciated. >>> >>> The webrev is at: >>> http://cr.opensolaris.org/~fb209375/sfwnv-openusb64/ 1. usr/src/lib/openusb/Makefile.sfw Combine lines 87 & 88 into ... -rm -rf $(VER) $(VER64) Use the predefined configure --prefix= value from Makefile.master, or better still use the ... ./configure $(CONFIGURE_OPTIONS) method throughout (there are lots of examples of that in the sfwnw gate now). Change 'env ' to 'env - ' throughout. I don't think you need the 'cd ..' on lines 48 and 38 Extract the VER= info from the METADATA file; if there isn't a METADATA file for this package then add one. 2. usr/src/lib/libusbugen/install-libusbugen & usr/src/lib/libusb/install-libusb Remove the 'write permission' bits on the files 3.usr/src/lib/libusbugen/install-libusbugen & usr/src/lib/libusb/install-libusb & usr/src/lib/openusb/install-sfw-64 Roland Mainz wrote: > use /usr/bin/ksh93 or /usr/bin/bash for install-sfw* and add > a $ set -o errexit # at the beginning and replace > ". ${SRC}/tools/install.subr" with > "source ${SRC}/tools/install.subr" (the > idea is to catch failures in the script and abort it at > that point, right now the script will just continue) 4. usr/src/lib/openusb/install-sfw-64 Pass VERS= info into script from the Makefile as an environment var. -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
