Darren, Below are my comments, some of them may duplicate Amanda's comment's ..
Paul Darren J Moffat wrote: > Please provide codereview for PSARC/2008/203 libmcrypt > > http://cr.opensolaris.org/~darrenm/libmcrypt/ > === Start of Comments === 1. usr/src/lib/libmcrypt/Makefile.sfw Change 'env ' to 'env - ' (if not already). Extract VER= info from METADATA file, see examples in recent integrations. Put this all on one line ... 108 -rm -rf \ 109 $(VER) \ 110 $(VER64) 2. usr/src/lib/libmcrypt/install-sfw & usr/src/lib/libmcrypt/install-sfw-64 Pass in VERS= info from Makefile.sfw as maybe environment variable 3. pkg dependencies You are using the default 'depend' file, have you checked your pkg has no other dependencies with the checker script? 4. usr/src/pkgdefs/SUNWlibmcrypt/pkginfo.tmpl Add pkg version to end of DESC= line, eg ... "............ (2.5.8)" 5. usr/src/pkgdefs/SUNWlibmcrypt/prototype_i386 & usr/src/pkgdefs/SUNWlibmcrypt/prototype_sparc Pkg name on comment line SUNWlibmng ??? Do you need the write permission on the file? 6. usr/src/pkgdefs/SUNWlibmcrypt/prototype_com Do you need the write permission on the files? 7. usr/src/lib/libmcrypt/METADATA Add NAME: field === End of Comments ===== -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
