Jason, This mainly looks good to me, just a few comments ..
Paul Jason Zhao wrote: > > I made several changes recently, and I think it had better > have a review again. The main changes is add a snort.conf > config file into the package, so the original SUNWsnort package > was split to 2 packages, SUNWsnortr and SUNWsnortu. SUNWsnortr > will only deliver snort.conf file to /etc, and SUNWsnortu is > original SUNWsnort package which deliver all the binaries. > > Here is webrev: > http://cr.opensolaris.org/~jxzhao/snort/webrev 1. usr/src/cmd/snort/sunman-stability Line ... 20 Availability SUNWsnort that should probably be now ... Availability SUNWsnortu SUNWsnortr 2. usr/src/cmd/snort/Makefile.sfw Should the 'configure options' explicitly define where the /etc/.. stuff lives ? 3. usr/src/pkgdefs/SUNWsnortr/pkginfo.tmpl As this is a root pkg you probably don't need the pkg version on the DESC= line (that way you may not need to update this file next time the src pkg version is updated. 4. usr/src/pkgdefs/SUNWsnortr/prototype_com Does this need to be preserver over a package update ? .. 50 f none etc/snort.conf 0644 root bin 5. usr/src/pkgdefs/SUNWsnortu/depend Does this have a dependency on the root pkg ? 6. usr/src/pkgdefs/SUNWsnortu/pkginfo.tmpl Put the version number on the DESC= line in brackets (the more common method), eg .. DESC="....... (2.8.3.2)" -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
