This looks okay to me. When you say you tried with the Sun compiler, did you try patching it to fix any build problems, or were there to many or to hard-to-patch?
Paul Jason Zhao wrote: > Hi, Paul, >> Jason, >> >> Changes look good to me. See below for a couple of things I missed >> first time around though ... >> >> Paul >> >> Jason Zhao wrote: >> ... cut .. >>> >>> The new webrev is updated, please review it again and tell me your >>> comments. >>> http://cr.opensolaris.org/~jxzhao/snort/webrev >> >> 1. usr/src/cmd/Makefile >> It looks as though this may need resyncing with the gate >> as it looks as though you may be try to change stuff you >> aren't really, ie. ... >> -apr-util/apr-util-1.3: apr/apr-1.3 mysql-5-1 ... >> +apr-util/apr-util-1.3: apr/apr-1.3 mysql-5-0 ... >> & >> -php5: apache2 mysql-5-1 postgres/postgresql-8.3 >> +php5: apache2 mysql-5-0 postgres/postgresql-8.3 > Thank you, I will sync with latest Makefile. >> >> 2. usr/src/cmd/snort/Makefile.sfw >> You are building this with gcc, could it have been built >> with the Sun compilers (the preferred compiler) ?? > I tried with latest CC, it is still could not work so far. > > The webrev is updated according to James' and your comments. > http://cr.opensolaris.org/~jxzhao/snort/webrev >
