Vivek, See comments below from my quick skip through ...
Paul Vivek T wrote: > I have posted a webrev for package " jexcelapi" which I am porting to > OpenSolaris and would like to request a code review. > > Please see below link > http://cr.opensolaris.org/~vivekrt/6816361-jexcelapi/ > > Let me know if any updates are required in the package files 1. usr/src/lib/jxl/METADATA Why not use the 'direct link' in the SRC: field ? ... "http://kent.dl.sourceforge.net/sourceforge/jexcelapi/jexcelapi_2_4_2.tar.gz"; Is the URL link correct ? ... 6 URL: http://asm.objectweb.org/ 2. usr/src/lib/jxl/Makefile.sfw Just an observation: having the version hard coded as 2_4_2 does mean that you will have to update this file when ever you do a version update integration, so maybe you can find a way to get around this. 3. usr/src/lib/jxl/sunman/jexcelapi.3 Says ... 41 /usr/share/lib/java/jexcelapi-2.4.2.jar maybe that should say ... /usr/share/lib/java/jexcelapi.jar so you don't have to update it every version update. 4. Package name SUNWjxl Observation: Maybe the package name should be SUNWjexcelapi which would be more meaningful ? 5. usr/src/pkgdefs/SUNWjxl/depend Lines ... 55 P SUNWj5rt JDK 1.5 run time environment 56 P SUNWj5dev JDK 1.5 development tools is this the right version of java ? END -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
