Vivek, See comments below from my quick skip through ...
Paul Vivek T wrote: > I have posted a webrev for package "cglib" which I am porting to > OpenSolaris and would like to request a code review. > > Please see below link > http://cr.opensolaris.org/~vivekrt/6816362-cglib-nodep/ 1. usr/src/lib/cglib/METADATA Again why no use the 'direct link' in the SRC: field ? 2. usr/src/lib/cglib/install-sfw VERS defined in Makefile.sfw has -nodep- in it ... VER=$(COMPONENT_NAME:sh)-nodep-$(COMPONENT_VERSION:sh) but when you add the symbolic link ... 70 _install L ${VERS}.jar ${JARDIR}/cglib.jar 444 the resultant link does not have it (cglib.jar), is that what you intended ? 3. usr/src/lib/cglib/sunman/cglib.3 Again maybe you should not include the version on .. 41 /usr/share/lib/java/cglib-2.1.3.jar and you have installed it as ... f none usr/share/lib/java/cglib-nodep-2.2.jar 4. usr/src/pkgdefs/SUNWcglib/depend Again is the version correct on ? ... 55 P SUNWj5rt JDK 1.5 run time environment 56 P SUNWj5dev JDK 1.5 development tools 5. Everything else looks okay to me END -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
