Another quick skip through, comments below ... Paul
PS. to sfwnv-discuss readers someone else also be looking at these !!! Vivek Titarmare wrote: > I have posted a webrev for package "xom" which I am porting to > OpenSolaris and would like to request a code review. > > Please see below link > http://cr.opensolaris.org/~vivekrt/6816367-xom/ === Start of Comments === 1. usr/src/lib/xom/METADATA SRC: link, why did you not put the following link here from the pkg's home-page ? .... http://www.cafeconleche.org/XOM/xom-1.2.1-src.tar.gz and why are you using version 1.1 when there is 1.2.1 ? 2. usr/src/pkgdefs/SUNWxom/depend Are the two 'zip' pkg dependencies correct ? 3. usr/src/pkgdefs/SUNWxom/prototype_com Should you be delivering all the 'tests' and 'samples' stuff ? === End of Comments =====
