Hi Paul, The changes are done and the webrev is uploaded for xstream.
Let me know if I should be considering this as approved. ( http://cr.opensolaris.org/~vivekrt/6816355-xstream/ ) Thanks, ~Vivek R. Titarmare -----Original Message----- From: Paul Cunningham [mailto:[email protected]] Sent: Friday, April 24, 2009 3:03 PM To: Vivek Titarmare Cc: sfwnv-discuss at opensolaris.org; Enrique.Lopezpineda at Sun.COM; Charles.Binford at Sun.COM Subject: Re: [sfwnv-discuss] Request code review for "xstream" Mainly looks good to me, but see comments below ... Paul Vivek Titarmare wrote: > I have posted a webrev for package "xstream" which I am porting to > OpenSolaris and would like to request a code review. > > Please see below link > http://cr.opensolaris.org/~vivekrt/6816355-xstream/ 1. pkg version Why are you integrating version 1.3 when there is 1.3.1 ? 2. usr/src/lib/xstream/install-sfw Should there be a symbolic link for xstream-benchmark.jar ? 3. usr/src/pkgdefs/SUNWxstream/copyright Maybe it should say what licence it is END -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
