Vivek, This mainly looks good to me, just a couple of comments below ...
Paul Vivek Titarmare wrote: > I have posted a webrev for package "dom4j" which I am porting to > OpenSolaris and would like to request a code review. > Please see below link > http://cr.opensolaris.org/~vivekrt/6816363-dom4j/ 1. source version Are you going to upgrade this to version 2.0 when it is a stable release? 2. usr/src/lib/dom4j/METADATA The NAME: string could be more descriptive and reflect, from home page ... "for working with XML, XPath and XSLT on the Java platform using the Java Collections Framework and with full support for DOM, SAX and JAXP" eg. something like ... "Java-based XML/XPath/XSLT Library with support for DOM/SAX/JAXP" And also maybe in the DESC= line of SUNWdom4j/pkginfo.tmpl
