Looks okay to me Paul
Chris Liu wrote: > I've updated it to > > http://cr.opensolaris.org/~chrisliu/SNDFILE_2/ > > "# libnet uses GCC compiler" is updated to "# libsndfile uses libFLAC > and libogg" > > Makefile and Targetdirs are all sync'ed to gate. > > Thanks, > - Chris > > > Paul Cunningham wrote: >> usr/src/pkgdefs/Makefile- you need to sync this with the gate >> otherwise it looks as though you are trying to delete stuff. >> >> usr/src/pkgdefs/SUNWlibsndfile/depend - whats the "53 # libnet uses >> GCC compiler" comment line for? >> >> otherwise it looks okay to me from my quick skip through. >> >> Paul >> >> >> Chris Liu wrote: >>> Thank you, Paul >>> My new webrev is at >>> http://cr.opensolaris.org/~chrisliu/SNDFILE_1/ >>> I followed all you suggestions. >>> >>>> === Start of Comments === >>>> >>>> 1. usr/src/lib/libsndfile/METADATA >>>> You might want to add a 'URL:' line, see .. >>>> p://wikis.sun.com/display/SFWNotes/Package+writing+gui >>>> delines" >>> Changed "COMMUNITY:" line to "URL:" >>> >>>> 2. usr/src/lib/libsndfile/Makefile.sfw >>>> Is "PREFIX=/usr" (line 30) used? If not delete it >>> deleted >>> >>>> You could extract the 'VER =' & 'TARBALL =' from the >>>> METADATA >>>> something like .. >>>> > VER =$(COMPONENT_NAME:sh)-$(COMPONENT_VERSION:sh) >>>> > TARBALL =$(VER).tar.bz2 >>> done >>> >>>> Could you have built this using the Sun Compiler >>>> (rather >>>> than gcc)? I think that is the preferred way! >>> Changed gnu compiler to SunStudio cc and CC >>> A new patch is also introduced because of CC >>> >>>> usr/src/lib/libsndfile/install-sfw >>>> The directories created by 'mkdir -p' should be in >>>> the >>>> 'Targetdirs' file (and removed from here). >>> Done >>> >>>> Roland Mainz wrote: >>>>> add a $ set -o errexit # at the beginning and >>>> replace >>>> > ". ${SRC}/tools/install.subr" with >>>>> "source ${SRC}/tools/install.subr" (the idea is to >>>> catch >>>>> failures in the script and abort it at that >>>> point, >>>> > right now the script will just continue) >>> Done >>> >>>> There is no sccs ident line in this file >>> Add >>> >>>> . usr/src/lib/libsndfile/sunman-stability >>>> SUNWlibnet ??? >>> Sorry about it. I copied this file and forgot to change >>> >>>> Id the 'Stability' level correct? >>> I saw most projects are with "Interface Stability Uncommitted" >>> >>> >>>> 5. usr/src/pkgdefs/SUNWlibsndfile/Makefile >>>> It doesn't look as though the sccs ident line is >>>> set >>>> up correctly! >>> changed to "#pragma ident" >>> >>>> usr/src/pkgdefs/SUNWlibsndfile/copyright >>>> Do you need to put the full licence in here - most >>>> people do now - so have you checked. >>> Attached >>> >>>> 7. usr/src/pkgdefs/SUNWlibsndfile/depend >>>> sccs ident line ? check it's set up correctly - it >>>> looks as though you just copied the expanded one >>>> from where-ever. >>> I missed two dependencies here, while gccruntime >>> is no longer a dependency. >>> The two dependencies are SUNWflac and SUNWogg-vorbis >>> >>>> Have you checked you have no other dependencies with >>>> the dependency checker script? >>>> Move the 'Copyright lines to after the >>>> "CDDL HEADER END" header. >>> Done >>> >>>> 8. usr/src/pkgdefs/SUNWlibsndfile/pkginfo.tmpl >>>> sccs ident line ? >>>> You might want to put the pkg version at the end >>>> of the DESC line .. >>>> "DESC="......... (1.0.17)" >>> Done >>> >>>> 9. usr/src/pkgdefs/SUNWlibsndfile/prototype_com >>>> + usr/src/pkgdefs/SUNWlibsndfile/prototype_i386 >>>> + usr/src/pkgdefs/SUNWlibsndfile/prototype_sparc >>>> sccs ident line ? >>> Done >>> >>>> End of Comments ===== >> >> > -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
